From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 5/7] tools,
 libxl: parse optional start gfn from the iomem config option
Date: Tue, 25 Mar 2014 15:45:08 +0000
Message-ID: <5331A484.7040206@linaro.org>
References: <1395712976-19454-1-git-send-email-avanzini.arianna@gmail.com>
	<1395712976-19454-6-git-send-email-avanzini.arianna@gmail.com>
	<5331A344.9000801@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5331A344.9000801@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, viktor.kleinik@globallogic.com
List-Id: xen-devel@lists.xenproject.org

On 03/25/2014 03:39 PM, Julien Grall wrote:
>> +                case 3: break;
>> +                case 2:
>> +                        /* default to 1:1 mapping */
>> +                        b_info->iomem[i].gfn = b_info->iomem[i].start;
>> +                        break;
> 
> If the iomem_range is initialized with the default value. You can defer
> this initialization in libxl.

To be more precise, I would move this set in libxl__domain_build_info_setdefault.

Regards,

-- 
Julien Grall