From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] build: fix sed usage in build process
Date: Tue, 25 Mar 2014 17:23:59 +0100
Message-ID: <5331AD9F.1000006@citrix.com>
References: <1395746443-61191-1-git-send-email-roger.pau@citrix.com>
	<53319B5D0200007800001C01@nat28.tlf.novell.com>
	<5331A796.4060708@citrix.com>
	<5331B7A30200007800001E4E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WSU8y-00057t-32
	for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 16:24:04 +0000
In-Reply-To: <5331B7A30200007800001E4E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 25/03/14 17:06, Jan Beulich wrote:
>>>> On 25.03.14 at 16:58, <roger.pau@citrix.com> wrote:
>> On 25/03/14 15:06, Jan Beulich wrote:
>>>>>> On 25.03.14 at 12:20, <roger.pau@citrix.com> wrote:
>>>> FreeBSD sed is not able to correctly parse the script
>>>> '/[0-9]/{s,00*,0,g;p}', so break it into two smaller scripts which
>>>> FreeBSD (and Linux) sed is able to parse.
>>>
>>> First of all - is this again a standard conformance issue? I can't see
>>> what's non-conformant with the old approach (which btw had been
>>> in place for quite long a time, so I'm puzzled by this being an issue
>>> only now), and for future reference purposes it would be nice to
>>> know what exactly should be avoided (i.e. to prevent a similar issue
>>> from getting introduced again later).
>>
>> Sorry, my regex skills are quite basic. The error is the following:
>>
>> sed: 1: "/[0-9]/{s,00*,0,g;p}": extra characters at the end of p command
> 
> Perhaps there's just a ; missing after the p?

Certainly, the following works fine:

sed -n '/[0-9]/{s,00*,0,g;p;}'

Since you are the one that found/fixed it, could you please submit the
patch?

Roger.