From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 32/34] tools/libxl: list_domains: shutdown
 is typed unsigned
Date: Tue, 25 Mar 2014 18:22:52 +0000
Message-ID: <5331C97C.3060009@citrix.com>
References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
	<1395766541-23979-33-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1WSW0R-0004MF-HH
	for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 18:23:23 +0000
In-Reply-To: <1395766541-23979-33-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: ian.campbell@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, tim@xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On 25/03/14 16:55, Julien Grall wrote:
> Don't need to check if shutdown is positive.
>
> Fix compilation with clang 3.5:
> xl_cmdimpl.c:3350:34: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare]
>                 (shutdown_reason >= 0 &&
>                  ~~~~~~~~~~~~~~~ ^  ~

Coverity-ID: 1055616

> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 8389468..e82620d 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3324,8 +3324,7 @@ static void list_domains(int verbose, int context, int claim, int numa,
>                  info[i].blocked ? 'b' : '-',
>                  info[i].paused ? 'p' : '-',
>                  info[i].shutdown ? 's' : '-',
> -                (shutdown_reason >= 0 &&
> -                 shutdown_reason < sizeof(shutdown_reason_letters)-1
> +                (shutdown_reason < sizeof(shutdown_reason_letters)-1
>                   ? shutdown_reason_letters[shutdown_reason] : '?'),
>                  info[i].dying ? 'd' : '-',
>                  ((float)info[i].cpu_time / 1e9));