From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v7 1/3] xen/libxc: Allow changing max number
 of hypervisor cpuid leaves
Date: Thu, 27 Mar 2014 10:04:29 -0400
Message-ID: <53342FED.1070208@oracle.com>
References: <1395703119-11502-1-git-send-email-boris.ostrovsky@oracle.com>
	<1395703119-11502-2-git-send-email-boris.ostrovsky@oracle.com>
	<1395926006.22909.128.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395926006.22909.128.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, JBeulich@suse.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, andrew.cooper3@citrix.com, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

On 03/27/2014 09:13 AM, Ian Campbell wrote:
> On Mon, 2014-03-24 at 19:18 -0400, Boris Ostrovsky wrote:
>> Add support for changing max number of hypervisor leaves from configuration
>> file.
>>
>> This number can be specified using xl's standard 'cpuid' option. Only lowest
>> 8 bits of leaf's 0x4000xx00 eax register are processed, all others are ignored.
> This sounds like it would need a docs update to go along with it, both
> to address this specific constraint and perhaps to give an example of
> the syntax (unless it is already obvious?).

This could to xl.cfg.5[.txt|.html], something in the cpuid option 
description. E.g.

   Note: when specifying CPUID for hypervisor leaves (0x4000xxxx major
   group) only the lowest 8 bits of leaf's 0x4000xx00 EAX register that 
signify
   maximum number of hypervisor leaves are processed, the rest are ignored.

As for example, this uses the same syntax as all other leaves so I am 
not sure
anything more is needed.


> Speaking of obvious syntaxes, does the list in libxl_cpuid_parse_config
> want updating so people can use maxhvleaf=2 instead of whatever the more
> obscure syntax would be?

Yes, I should add this.

Thanks.
-boris