From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 30/34] xen: Add missing includes on different files Date: Thu, 27 Mar 2014 17:30:01 +0000 Message-ID: <53346019.60605@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> <1395766541-23979-31-git-send-email-julien.grall@linaro.org> <1395940318.22909.223.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WTE7x-0007cr-Cu for xen-devel@lists.xenproject.org; Thu, 27 Mar 2014 17:30:05 +0000 Received: by mail-ee0-f41.google.com with SMTP id t10so3210261eei.28 for ; Thu, 27 Mar 2014 10:30:04 -0700 (PDT) In-Reply-To: <1395940318.22909.223.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Daniel De Graaf , tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/27/2014 05:11 PM, Ian Campbell wrote: > On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote: >> This was spotted by -Wmissing-prototypes, which we can't enable because there >> is exported function for assembly. I'm not sure if we need to add a prototype >> for them. > > What exactly is the issue here? There a bunch of functions (see below for ARM) where the prototype is not defined before. Mainly because theses functions are used by the assembly code so we don't need to give a prototype. do_trap_* start_xen start_secondary leave_hypervisor_tail Regards, -- Julien Grall