From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 31/34] tools: Disable ignored-attributes
 warning when compiling with clang
Date: Thu, 27 Mar 2014 17:49:30 +0000
Message-ID: <533464AA.8080807@linaro.org>
References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
	<1395766541-23979-32-git-send-email-julien.grall@linaro.org>
	<1395940454.22909.225.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WTEQo-0002QB-8W
	for xen-devel@lists.xenproject.org; Thu, 27 Mar 2014 17:49:34 +0000
Received: by mail-ee0-f48.google.com with SMTP id b57so3145501eek.21
	for <xen-devel@lists.xenproject.org>;
	Thu, 27 Mar 2014 10:49:32 -0700 (PDT)
In-Reply-To: <1395940454.22909.225.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 03/27/2014 05:14 PM, Ian Campbell wrote:
> On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote:
>> Clang 3.5 will fail to build most of the tools because aligned attribute
>> is not used sometimes:
>>
>> In file included from xc_core.c:64:
>> In file included from ./xg_private.h:30:
>> In file included from ./xenctrl.h:55:
>> ../../tools/include/xen/foreign/x86_64.h:198:47: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes]
>>     __align8__ uint64_t evtchn_pending[sizeof(__align8__ uint64_t) * 8];
>>                                               ^~~~~~~~~~
>> ../../tools/include/xen/foreign/x86_64.h:13:36: note: expanded from macro '__align8__'
>>  # define __align8__ __attribute__((aligned (8)))
>>                                    ^~~~~~~~~~~
>> ../../tools/include/xen/foreign/x86_64.h:199:44: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes]
>>     __align8__ uint64_t evtchn_mask[sizeof(__align8__ uint64_t) * 8];
> 
> Is sizeof(__align8__ uint64_t) != sizeof(uint64_t) under any
> circumstances? IOW can't we just drop the __align8__ here?

I don't think. This code is generated by mkheader.py. I will look at it
and see if I can modify it.

Regards,

-- 
Julien Grall