From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Tim Deegan <tim@xen.org>,
stefano.stabellini@citrix.com
Subject: Re: [PATCH 1/3] xen/arm: Move p2m context save/restore in a separate function
Date: Fri, 28 Mar 2014 13:23:27 +0000 [thread overview]
Message-ID: <533577CF.90301@linaro.org> (raw)
In-Reply-To: <1396010868.8670.40.camel@kazak.uk.xensource.com>
On 03/28/2014 12:47 PM, Ian Campbell wrote:
> On Fri, 2014-03-28 at 12:44 +0000, Julien Grall wrote:
>> Hi Ian,
>>
>> On 03/21/2014 09:19 AM, Ian Campbell wrote:
>>> On Thu, 2014-03-20 at 17:59 +0000, Julien Grall wrote:
>>>
>>>>> Are all of these isb()s necessary? I guess this is only code motion,
>>>>> so in any case, Acked-by: Tim Deegan <tim@xen.org> (for the whole series)
>>>>> but it seems like at least the one after the VTTBR write could go?
>>>>
>>>> Thanks for the review.
>>>>
>>>> Yes, the isb() right after VTBBR can be removed.
>>>
>>> Actually I think there are probably loads of barriers in the context
>>> switch path which can be dropped in favour of a final one at the end,
>>> not all that much stuff there relies on stuff which is reloaded before
>>> it (of course we should keep barriers for cases where there is a
>>> dependence).
>>
>> Sorry for the late answer. Shall I rework this patch and remove the
>> duplicated isb and HCR_VM?
>
> If you need to rebase/resend for some other reason then please fold this
> in. If not then please send a follow up patch.
I will send a separate patch to remove unnecessary code in this function.
--
Julien Grall
next prev parent reply other threads:[~2014-03-28 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 15:43 [PATCH 0/3] xen/arm: setup a sane EL1 state while building domain 0 Julien Grall
2014-03-19 15:43 ` [PATCH 1/3] xen/arm: Move p2m context save/restore in a separate function Julien Grall
2014-03-20 17:23 ` Tim Deegan
2014-03-20 17:59 ` Julien Grall
2014-03-21 9:19 ` Ian Campbell
2014-03-28 12:44 ` Julien Grall
2014-03-28 12:47 ` Ian Campbell
2014-03-28 13:23 ` Julien Grall [this message]
2014-04-01 10:53 ` Ian Campbell
2014-03-21 16:52 ` Ian Campbell
2014-03-19 15:43 ` [PATCH 2/3] xen/arm: Use p2m_restore_state in construct_dom0 Julien Grall
2014-03-21 16:50 ` Ian Campbell
2014-03-28 13:26 ` Julien Grall
2014-03-28 13:51 ` Ian Campbell
2014-03-19 15:43 ` [PATCH 3/3] xen/arm: Don't need to export p2m_load_VTTBR Julien Grall
2014-03-21 16:52 ` Ian Campbell
2014-04-01 10:53 ` [PATCH 0/3] xen/arm: setup a sane EL1 state while building domain 0 Ian Campbell
2014-04-01 11:33 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533577CF.90301@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).