From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/3] xen/arm: Move p2m context save/restore in a separate function Date: Fri, 28 Mar 2014 13:23:27 +0000 Message-ID: <533577CF.90301@linaro.org> References: <1395243819-30380-1-git-send-email-julien.grall@linaro.org> <1395243819-30380-2-git-send-email-julien.grall@linaro.org> <20140320172338.GG68664@deinos.phlegethon.org> <532B2C94.5060400@linaro.org> <1395393567.3104.46.camel@kazak.uk.xensource.com> <53356E95.2080103@linaro.org> <1396010868.8670.40.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WTWks-0000vV-1p for xen-devel@lists.xenproject.org; Fri, 28 Mar 2014 13:23:30 +0000 Received: by mail-ee0-f42.google.com with SMTP id d17so4078682eek.15 for ; Fri, 28 Mar 2014 06:23:28 -0700 (PDT) In-Reply-To: <1396010868.8670.40.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Tim Deegan , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/28/2014 12:47 PM, Ian Campbell wrote: > On Fri, 2014-03-28 at 12:44 +0000, Julien Grall wrote: >> Hi Ian, >> >> On 03/21/2014 09:19 AM, Ian Campbell wrote: >>> On Thu, 2014-03-20 at 17:59 +0000, Julien Grall wrote: >>> >>>>> Are all of these isb()s necessary? I guess this is only code motion, >>>>> so in any case, Acked-by: Tim Deegan (for the whole series) >>>>> but it seems like at least the one after the VTTBR write could go? >>>> >>>> Thanks for the review. >>>> >>>> Yes, the isb() right after VTBBR can be removed. >>> >>> Actually I think there are probably loads of barriers in the context >>> switch path which can be dropped in favour of a final one at the end, >>> not all that much stuff there relies on stuff which is reloaded before >>> it (of course we should keep barriers for cases where there is a >>> dependence). >> >> Sorry for the late answer. Shall I rework this patch and remove the >> duplicated isb and HCR_VM? > > If you need to rebase/resend for some other reason then please fold this > in. If not then please send a follow up patch. I will send a separate patch to remove unnecessary code in this function. -- Julien Grall