From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ Date: Mon, 31 Mar 2014 16:45:08 +0100 Message-ID: <53398D84.3020901@linaro.org> References: <1390581822-32624-1-git-send-email-julien.grall@linaro.org> <1390581822-32624-8-git-send-email-julien.grall@linaro.org> <1392810905.29739.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WUeOd-0003sz-Kd for xen-devel@lists.xenproject.org; Mon, 31 Mar 2014 15:45:12 +0000 Received: by mail-we0-f181.google.com with SMTP id q58so4783772wes.26 for ; Mon, 31 Mar 2014 08:45:10 -0700 (PDT) In-Reply-To: <1392810905.29739.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Keir Fraser , stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 02/19/2014 11:55 AM, Ian Campbell wrote: > On Fri, 2014-01-24 at 16:43 +0000, Julien Grall wrote: >> On ARM, it may happen (eg ARM SMMU) to setup multiple handler for the same >> interrupt. > > Mention here that you are therefore creating a linked list of actions > for each interrupt. > > If you use xen/list.h for this then you get a load of helpers and > iterators which would save you open coding them. I've tried to use xen/list.h. The amount of code it's basically the same and we I have to write open code to get the first element of the list and complexify release_dt_irq which is not nice. I will stick to the version with "next" for the next version of this series. Regards, -- Julien Grall