Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends

["Roger Pau Monné" <roger.pau@citrix.com>]

Ping?

On 26/02/14 18:01, Roger Pau Monné wrote:
> On 26/02/14 17:30, Lars Ellenberg wrote:
>> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote:
>>>
>>> I've realized I haven't Cc'ed the drbd developers lists, so adding it now.
>>
>> We do read the user's list just as well.
>> Our -dev is actually mainly intended for "coordination".
>>
>>> On 20/02/14 16:59, Roger Pau Monne wrote:
>>>> The type written to xenstore by libxl when attaching a drbd backend is
>>>> "phy", not "drbd", so handle this case also.
>>
>> If you say so; you should know ;-)
>> Did this change at some point?
> 
> I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as
> type. Probably the old xend toolstack was setting type to "drbd", and
> that's why the script checked for drbd.
> 
> IMHO, setting the type to phy is the right thing to do, since drbd ends
> up presenting a block device which is handled by blkback.
> 
>> I personally have not used this script in a long while...
>>
>> Do you ("citrix") have this in some
>> regression/integration testing yourself?
> 
> Not in Xen OSS Test suite [0], although I have no idea if other products
> based on Xen perform any kind of tests with drbd.
> 
> [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>