From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends Date: Tue, 1 Apr 2014 09:12:21 +0200 Message-ID: <533A66D5.1020103@citrix.com> References: <1392911976-37506-1-git-send-email-roger.pau@citrix.com> <530E05DA.6070500@citrix.com> <20140226163036.GE3154@soda.linbit> <530E1E07.4090007@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WUsrz-0002G6-Qm for xen-devel@lists.xenproject.org; Tue, 01 Apr 2014 07:12:28 +0000 In-Reply-To: <530E1E07.4090007@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, drbd-user@lists.linbit.com List-Id: xen-devel@lists.xenproject.org Ping? On 26/02/14 18:01, Roger Pau Monn=E9 wrote: > On 26/02/14 17:30, Lars Ellenberg wrote: >> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monn=E9 wrote: >>> >>> I've realized I haven't Cc'ed the drbd developers lists, so adding it n= ow. >> >> We do read the user's list just as well. >> Our -dev is actually mainly intended for "coordination". >> >>> On 20/02/14 16:59, Roger Pau Monne wrote: >>>> The type written to xenstore by libxl when attaching a drbd backend is >>>> "phy", not "drbd", so handle this case also. >> >> If you say so; you should know ;-) >> Did this change at some point? > = > I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as > type. Probably the old xend toolstack was setting type to "drbd", and > that's why the script checked for drbd. > = > IMHO, setting the type to phy is the right thing to do, since drbd ends > up presenting a block device which is handled by blkback. > = >> I personally have not used this script in a long while... >> >> Do you ("citrix") have this in some >> regression/integration testing yourself? > = > Not in Xen OSS Test suite [0], although I have no idea if other products > based on Xen perform any kind of tests with drbd. > = > [0] http://xenbits.xen.org/gitweb/?p=3Dosstest.git;a=3Dsummary > = > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > =