From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v8 16/20] xenctx: Fix handling of !guest_protected_mode Date: Tue, 01 Apr 2014 14:35:01 -0400 Message-ID: <533B06D5.30003@terremark.com> References: <1395947147-5262-1-git-send-email-dslutz@verizon.com> <1395947147-5262-17-git-send-email-dslutz@verizon.com> <1396361691.8667.202.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396361691.8667.202.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Don Slutz Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/01/14 10:14, Ian Campbell wrote: > On Thu, 2014-03-27 at 15:05 -0400, Don Slutz wrote: >> Start with adding the code to the 64 bit path that the 32 bit path >> has. > One for people who keep x86 in their brains, is it possible for a > processor to be in 64-bit non-protected mode? Not in the way the question is asked. This case is: Breakpoint 1, instr_pointer (ctx=ctx@entry=0x7fffffffd040) at xenctx.c:413 413 { (gdb) p ctxt_word_size $1 = 8 (gdb) p guest_word_size $2 = 4 I.E. the context is in 64, the guest is not. This is why: void print_ctx(vcpu_guest_context_any_t *ctx) { if (ctxt_word_size == 4) print_ctx_32(&ctx->x32); else if (guest_word_size == 4) print_ctx_32on64(&ctx->x64); else print_ctx_64(&ctx->x64); } exists. -Don Slutz