From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 2/6] xen: arm: consolidate body of flush_xen_data_tlb_range_va_local Date: Thu, 03 Apr 2014 11:56:00 +0100 Message-ID: <533D3E40.5020605@linaro.org> References: <1396515560.4211.33.camel@kazak.uk.xensource.com> <1396515585-5737-2-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396515585-5737-2-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/03/2014 09:59 AM, Ian Campbell wrote: > +/* > + * Flush a range of VA's hypervisor mappings from the data TLB of the > + * local processor. This is not sufficient when changing code mappings > + * or for self modifying code. > + */ > +static inline void flush_xen_data_tlb_range_va_local(unsigned long va, > + unsigned long size) > +{ > + unsigned long end = va + size; > + dsb(sy); /* Ensure preceding are visible */ > + while ( va < end ) { while ( va < end ) { Except this minor coding style error (I've noticed it was there before): Acked-by: Julien Grall Regards, -- Julien Grall