From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
ian.campbell@citrix.com, tim@xen.org
Subject: Re: [PATCH v2 15/16] xen: IRQ: Add dev_id parameter to release_irq
Date: Fri, 04 Apr 2014 09:39:32 +0100 [thread overview]
Message-ID: <533E6FC4.4050505@linaro.org> (raw)
In-Reply-To: <533E7FCC0200007800005810@nat28.tlf.novell.com>
On 04/04/2014 08:47 AM, Jan Beulich wrote:
>>>> On 03.04.14 at 22:42, <julien.grall@linaro.org> wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -983,7 +983,7 @@ int __init request_irq(unsigned int irq,
>> return retval;
>> }
>>
>> -void __init release_irq(unsigned int irq)
>> +void release_irq(unsigned int irq, const void *dev_id)
>
> Why? There shouldn't be any post-init use for it (and in fact the
> function is - as you validly say - entirely unused right now), so
> there's no need for it to stay in memory.
Oops, my mistake. The x86 version should keep the __init but not ARM. I
will re-add the __init in the next version.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-04-04 8:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 20:41 [PATCH v2 00/16] Interrupt management reworking Julien Grall
2014-04-03 20:41 ` [PATCH v2 01/16] xen/arm: timer: replace timer_dt_irq by timer_get_irq Julien Grall
2014-04-07 13:10 ` Ian Campbell
2014-04-07 13:24 ` Julien Grall
2014-04-03 20:41 ` [PATCH v2 02/16] xen/arm: IRQ: Use default irq callback from common code for no_irq_type Julien Grall
2014-04-07 13:10 ` Ian Campbell
2014-04-03 20:41 ` [PATCH v2 03/16] xen/arm: IRQ: Rename irq_cfg into arch_irq_desc Julien Grall
2014-04-07 13:10 ` Ian Campbell
2014-04-03 20:41 ` [PATCH v2 04/16] xen/arm: IRQ: move gic {, un}lock in gic_set_irq_properties Julien Grall
2014-04-03 20:41 ` [PATCH v2 05/16] xen/arm: IRQ: drop irq parameter in __setup_irq Julien Grall
2014-04-07 13:05 ` Ian Campbell
2014-04-07 13:26 ` Julien Grall
2014-04-03 20:41 ` [PATCH v2 06/16] xen/arm: IRQ: remove __init from setup_dt_irq, request_dt_irq and release_irq Julien Grall
2014-04-07 13:11 ` Ian Campbell
2014-04-03 20:41 ` [PATCH v2 07/16] xen/arm: IRQ: Move IRQ management from gic.c to irq.c Julien Grall
2014-04-07 13:07 ` Ian Campbell
2014-04-07 13:34 ` Julien Grall
2014-04-03 20:41 ` [PATCH v2 08/16] xen/arm: IRQ Introduce irq_get_domain Julien Grall
2014-04-07 13:15 ` Ian Campbell
2014-04-07 13:44 ` Julien Grall
2014-04-03 20:42 ` [PATCH v2 09/16] xen/arm: IRQ: Add lock contrainst for gic_irq_{startup, shutdown} Julien Grall
2014-04-07 13:27 ` Ian Campbell
2014-04-07 14:45 ` Julien Grall
2014-04-03 20:42 ` [PATCH v2 10/16] xen/arm: IRQ: Don't need to have a specific function to route IRQ to Xen Julien Grall
2014-04-07 13:53 ` Ian Campbell
2014-04-07 14:15 ` Julien Grall
2014-04-03 20:42 ` [PATCH v2 11/16] xen/arm: IRQ: Protect IRQ to be shared between domains and XEN Julien Grall
2014-04-07 14:46 ` Ian Campbell
2014-04-07 14:53 ` Julien Grall
2014-04-07 15:12 ` Ian Campbell
2014-04-07 15:32 ` Julien Grall
2014-04-03 20:42 ` [PATCH v2 12/16] xen/serial: remove serial_dt_irq Julien Grall
2014-04-07 14:49 ` Ian Campbell
2014-04-03 20:42 ` [PATCH v2 13/16] xen/arm: IRQ: Store IRQ type in arch_irq_desc Julien Grall
2014-04-07 15:03 ` Ian Campbell
2014-04-07 16:06 ` Julien Grall
2014-04-07 16:26 ` Ian Campbell
2014-04-08 11:46 ` Julien Grall
2014-04-08 15:30 ` Ian Campbell
2014-04-08 15:50 ` Julien Grall
2014-04-08 15:54 ` Ian Campbell
2014-04-03 20:42 ` [PATCH v2 14/16] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq Julien Grall
2014-04-07 15:06 ` Ian Campbell
2014-04-07 16:11 ` Julien Grall
2014-04-03 20:42 ` [PATCH v2 15/16] xen: IRQ: Add dev_id parameter to release_irq Julien Grall
2014-04-04 7:47 ` Jan Beulich
2014-04-04 8:39 ` Julien Grall [this message]
2014-04-07 15:08 ` Ian Campbell
2014-04-03 20:42 ` [PATCH v2 16/16] xen/arm: IRQ: Handle multiple action per IRQ Julien Grall
2014-04-04 7:59 ` Jan Beulich
2014-04-04 8:52 ` Julien Grall
2014-04-04 9:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533E6FC4.4050505@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).