From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 15/16] xen: IRQ: Add dev_id parameter to release_irq Date: Fri, 04 Apr 2014 09:39:32 +0100 Message-ID: <533E6FC4.4050505@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> <1396557727-19102-16-git-send-email-julien.grall@linaro.org> <533E7FCC0200007800005810@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVzew-0004Gf-Ph for xen-devel@lists.xenproject.org; Fri, 04 Apr 2014 08:39:35 +0000 Received: by mail-wi0-f182.google.com with SMTP id d1so759480wiv.15 for ; Fri, 04 Apr 2014 01:39:33 -0700 (PDT) In-Reply-To: <533E7FCC0200007800005810@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On 04/04/2014 08:47 AM, Jan Beulich wrote: >>>> On 03.04.14 at 22:42, wrote: >> --- a/xen/arch/x86/irq.c >> +++ b/xen/arch/x86/irq.c >> @@ -983,7 +983,7 @@ int __init request_irq(unsigned int irq, >> return retval; >> } >> >> -void __init release_irq(unsigned int irq) >> +void release_irq(unsigned int irq, const void *dev_id) > > Why? There shouldn't be any post-init use for it (and in fact the > function is - as you validly say - entirely unused right now), so > there's no need for it to stay in memory. Oops, my mistake. The x86 version should keep the __init but not ARM. I will re-add the __init in the next version. Regards, -- Julien Grall