From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 01/15] xen/arm: register mmio handler at
	runtime
Date: Fri, 04 Apr 2014 14:06:10 +0100
Message-ID: <533EAE42.4090300@linaro.org>
References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
	<1396612593-443-2-git-send-email-vijay.kilari@gmail.com>
	<533EA307.4000900@linaro.org>
	<CALicx6u-6Gz=LcsDjH+Pb_FG2GzXxMHJOqHCZrfDdwBtqR8dQQ@mail.gmail.com>
	<1396615352.4211.216.camel@kazak.uk.xensource.com>
	<533EAB84.3090005@linaro.org>
	<1396616360.4211.226.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1396616360.4211.226.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Vijay Kilari <vijay.kilari@gmail.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/04/2014 01:59 PM, Ian Campbell wrote:
> On Fri, 2014-04-04 at 13:54 +0100, Julien Grall wrote:
>> On 04/04/2014 01:42 PM, Ian Campbell wrote:
>>> On Fri, 2014-04-04 at 18:00 +0530, Vijay Kilari wrote:
>>>>>> +    handler->mmio_handlers[handler->num_entries++] = handle;
>>>>>> +    spin_unlock_irqrestore(&handler_lock, flags);
>>>>>> +}
>>>>>>  /*
>>>>>>   * Local variables:
>>>>>>   * mode: C
>>>>>> diff --git a/xen/arch/arm/io.h b/xen/arch/arm/io.h
>>>>>> index 8d252c0..5fc1660 100644
>>>>>> --- a/xen/arch/arm/io.h
>>>>>> +++ b/xen/arch/arm/io.h
>>>>>
>>>>> As you are modifying this header. Can you move it in
>>>> include/asm-arm?
>>>> OK.
>>>
>>> Please don't mix movement and modifications. Unless you are adding uses
>>> from outside xen/arch/arm requiring ugly relative includes there is no
>>> need to move this IMHO.
>>
>> My point was to clean up and having a single place for every headers.
> 
> Why? What your goal with this "clean up"?

His changes will basically rewrite 80% of the header. So it was a good
time to move it.

> If a header is only used by .c files in the same directory then it is
> absolutely fine for the header to live in that directory and be included
> with
> 	#include "foo.h"

We have many headers in include/asm-arm which are only used on arch/arm.

Anyway it was a suggestion... nothing else.

Regards,


-- 
Julien Grall