From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 11/15] xen/arm: make GIC context data version specific Date: Fri, 04 Apr 2014 15:09:01 +0100 Message-ID: <533EBCFD.20403@linaro.org> References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com> <1396612593-443-12-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396612593-443-12-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hello Vijaya, Thank you for the patch. On 04/04/2014 12:56 PM, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > GIC context data is dependent on hardware version > make the contents of gic context data structure > as version specific and access accordingly > > Signed-off-by: Vijaya Kumar K > --- > xen/arch/arm/gic-v2.c | 15 ++++++++------- > xen/include/asm-arm/gic.h | 11 ++++++++--- > 2 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index 06ed12b..4bcb392 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -96,6 +96,7 @@ static int gic_state_init(struct vcpu *v) > v->arch.gic_state = xzalloc(struct gic_state_data); > if ( !v->arch.gic_state ) > return -ENOMEM; > + v->arch.gic_state->version = 2; I would prefer an enum rather than a fixed number. Regards, -- Julien Grall