Re: [PATCH v2 01/15] xen/arm: register mmio handler at runtime

[Julien Grall <julien.grall@linaro.org>]

On 04/04/2014 04:24 PM, Vijay Kilari wrote:

>>> As I said on the previous version, it would be nice to remove check
>>> callback in the mmio_handler and replace it by addr/size. It's better if
>>> we might want to change the place in the memory following the guest.
>>>
>>> So the result function would be:
>>>
>>> register_mmio_handler(struct domain *d, read_t read, write_t write,
>>> addr, size);
>>>
>> OK.
>    Though you suggested, I kept this check handler because it gives flexibility
> for driver to make additional checks if required apart from just checking for
> address range.

What kind of checks? If the handler is registered to a domain that means
we want to use it, right? It would seem strange to trap once a while.

Regards,

-- 
Julien Grall