From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
suravee.suthikulpanit@amd.com
Subject: Re: [PATCH v2 1/3] x86/AMD: feature masking is unavailable on Fam11
Date: Mon, 7 Apr 2014 11:14:32 +0100 [thread overview]
Message-ID: <53427A88.70608@citrix.com> (raw)
In-Reply-To: <53428EFB02000078000060B7@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]
On 07/04/14 10:41, Jan Beulich wrote:
> Reported-by: Aravind Gopalakrishnan<aravind.gopalakrishnan@amd.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -107,6 +107,10 @@ static void __devinit set_cpuidmask(cons
> ASSERT((status == not_parsed) && (smp_processor_id() == 0));
> status = no_mask;
>
> + /* Fam11 doesn't support masking at all. */
> + if (c->x86 == 0x11)
> + return;
> +
> if (~(opt_cpuid_mask_ecx & opt_cpuid_mask_edx &
> opt_cpuid_mask_ext_ecx & opt_cpuid_mask_ext_edx)) {
> feat_ecx = opt_cpuid_mask_ecx;
> @@ -176,7 +180,6 @@ static void __devinit set_cpuidmask(cons
> extfeat_ecx, extfeat_edx);
>
> setmask:
> - /* FIXME check if processor supports CPUID masking */
> /* AMD processors prior to family 10h required a 32-bit password */
> if (c->x86 >= 0x10) {
> wrmsr(MSR_K8_FEATURE_MASK, feat_edx, feat_ecx);
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2136 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-07 10:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 9:36 [PATCH v2 0/3] x86/AMD: feature masking adjustments Jan Beulich
2014-04-07 9:41 ` [PATCH v2 1/3] x86/AMD: feature masking is unavailable on Fam11 Jan Beulich
2014-04-07 10:14 ` Andrew Cooper [this message]
2014-04-07 9:43 ` [PATCH v2 2/3] x86/AMD: support further feature masking MSRs Jan Beulich
2014-04-07 10:23 ` Andrew Cooper
2014-04-07 11:53 ` Jan Beulich
2014-04-07 12:09 ` Andrew Cooper
2014-04-07 15:21 ` Boris Ostrovsky
2014-04-08 7:15 ` Jan Beulich
2014-04-08 13:50 ` Boris Ostrovsky
2014-04-08 14:02 ` Jan Beulich
2014-04-08 14:14 ` Boris Ostrovsky
2014-04-08 14:33 ` Jan Beulich
2014-04-08 15:14 ` Boris Ostrovsky
2014-04-09 15:39 ` Aravind Gopalakrishnan
2014-04-09 15:50 ` Jan Beulich
2014-04-07 9:43 ` [PATCH v2 3/3] x86/AMD: clean up pre-canned family/revision handling for CPUID masking Jan Beulich
2014-04-07 10:48 ` Andrew Cooper
2014-04-07 11:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53427A88.70608@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=keir@xen.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).