From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH linux v2] arm: xen: implement multicall hypercall support.
Date: Mon, 7 Apr 2014 13:59:18 +0100 [thread overview]
Message-ID: <5342A126.2000102@citrix.com> (raw)
In-Reply-To: <1396875419.22845.69.camel@kazak.uk.xensource.com>
On 07/04/14 13:56, Ian Campbell wrote:
> On Mon, 2014-04-07 at 13:51 +0100, David Vrabel wrote:
>> On 07/04/14 13:48, Ian Campbell wrote:
>>> --- a/arch/x86/include/asm/xen/interface.h
>>> +++ b/arch/x86/include/asm/xen/interface.h
>>> @@ -54,6 +54,9 @@ typedef unsigned long xen_pfn_t;
>>> #define PRI_xen_pfn "lx"
>>> typedef unsigned long xen_ulong_t;
>>> #define PRI_xen_ulong "lx"
>>> +typedef long xen_long_t;
>>> +#define PRI_xen_long "lx"
>>
>> Do you really want signed values to be printed as unsigned?
>
> There's no signed hex format code (is there?) so it was a choice between
> signed decimal or unsigned hex, I went with the latter for consistency
> with PRI_xen_ulong.
>
> In the absence of a PRIx64 vs PRId64 type distinction there's probably
> no universally correct answer.
Ok.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2014-04-07 12:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 12:48 [PATCH xen v2] xen: arm: fully implement multicall interface Ian Campbell
2014-04-07 12:48 ` [PATCH linux v2] arm: xen: implement multicall hypercall support Ian Campbell
2014-04-07 12:51 ` David Vrabel
2014-04-07 12:56 ` Ian Campbell
2014-04-07 12:59 ` David Vrabel [this message]
2014-04-08 17:11 ` Stefano Stabellini
2014-04-07 13:27 ` [PATCH xen v2] xen: arm: fully implement multicall interface Jan Beulich
2014-04-07 13:42 ` Ian Campbell
2014-04-07 15:13 ` Jan Beulich
2014-04-07 15:18 ` Ian Campbell
2014-04-08 7:13 ` Jan Beulich
2014-04-08 11:18 ` Ian Campbell
2014-04-08 11:29 ` Jan Beulich
2014-04-08 11:39 ` Ian Campbell
2014-04-08 13:08 ` Jan Beulich
2014-04-08 13:14 ` Ian Campbell
2014-04-17 12:51 ` Ian Campbell
2014-04-07 15:24 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5342A126.2000102@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).