From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH linux v2] arm: xen: implement multicall hypercall support. Date: Mon, 7 Apr 2014 13:59:18 +0100 Message-ID: <5342A126.2000102@citrix.com> References: <1396874925-751-1-git-send-email-ian.campbell@citrix.com> <1396874935-20513-1-git-send-email-ian.campbell@citrix.com> <53429F64.2000509@citrix.com> <1396875419.22845.69.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396875419.22845.69.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/04/14 13:56, Ian Campbell wrote: > On Mon, 2014-04-07 at 13:51 +0100, David Vrabel wrote: >> On 07/04/14 13:48, Ian Campbell wrote: >>> --- a/arch/x86/include/asm/xen/interface.h >>> +++ b/arch/x86/include/asm/xen/interface.h >>> @@ -54,6 +54,9 @@ typedef unsigned long xen_pfn_t; >>> #define PRI_xen_pfn "lx" >>> typedef unsigned long xen_ulong_t; >>> #define PRI_xen_ulong "lx" >>> +typedef long xen_long_t; >>> +#define PRI_xen_long "lx" >> >> Do you really want signed values to be printed as unsigned? > > There's no signed hex format code (is there?) so it was a choice between > signed decimal or unsigned hex, I went with the latter for consistency > with PRI_xen_ulong. > > In the absence of a PRIx64 vs PRId64 type distinction there's probably > no universally correct answer. Ok. Reviewed-by: David Vrabel David