From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 01/16] xen/arm: timer: replace timer_dt_irq by timer_get_irq Date: Mon, 07 Apr 2014 14:24:37 +0100 Message-ID: <5342A715.2030007@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> <1396557727-19102-2-git-send-email-julien.grall@linaro.org> <1396876227.22845.79.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WX9XW-0003B4-9V for xen-devel@lists.xenproject.org; Mon, 07 Apr 2014 13:24:42 +0000 Received: by mail-ee0-f53.google.com with SMTP id b57so638670eek.40 for ; Mon, 07 Apr 2014 06:24:38 -0700 (PDT) In-Reply-To: <1396876227.22845.79.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/07/2014 02:10 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:41 +0100, Julien Grall wrote: >> The function is nearly only used to retrieve the IRQ number. >> >> There is one place where the IRQ type is used (in domain_build.c) but >> as the timer IRQ is virtualised for guest we might not have the same property >> (e.g active-low level sensitive interrupt). > > Is this statement impacted at all by Stefano switching things to use the > LR.HW bit? The LR.HW is only used for physical interrupt routed to the guest. As the timer interrupt is virtualised it should not impact anything. Regards, -- Julien Grall