From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 11/16] xen/arm: IRQ: Protect IRQ to be shared between domains and XEN Date: Mon, 07 Apr 2014 16:32:58 +0100 Message-ID: <5342C52A.7020103@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> <1396557727-19102-12-git-send-email-julien.grall@linaro.org> <1396881997.22845.112.camel@kazak.uk.xensource.com> <5342BBCE.8060808@linaro.org> <1396883554.22845.129.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXBXh-00041V-BZ for xen-devel@lists.xenproject.org; Mon, 07 Apr 2014 15:33:01 +0000 Received: by mail-ee0-f43.google.com with SMTP id e53so770493eek.16 for ; Mon, 07 Apr 2014 08:32:59 -0700 (PDT) In-Reply-To: <1396883554.22845.129.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/07/2014 04:12 PM, Ian Campbell wrote: > On Mon, 2014-04-07 at 15:53 +0100, Julien Grall wrote: >>>> Xen ... >>>> >>>> Also avoid to rely on wrong behaviour when Xen is routing an IRQ to DOM0. >>> >>> "Also avoid relying on the wrong behaviour ..." perhaps? If that not >>> then I'm not sure what this is referring to. Apart from that doubt the >>> code looks ok to me. >> >> Currently Xen doesn't check the return of routing the IRQ into DOM0. So, >> if it fails we silently ignore the error. > > OK, that's what I thought you were talking about then. You might want > append to the existing sentence: "Therefore check the return code from > XXX in YYYY." to make it clear what it means. I will update the commit message. Regards, -- Julien Grall