From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 14/16] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq Date: Mon, 07 Apr 2014 17:11:11 +0100 Message-ID: <5342CE1F.7080400@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> <1396557727-19102-15-git-send-email-julien.grall@linaro.org> <1396883196.22845.126.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXC8g-0007Il-Kh for xen-devel@lists.xenproject.org; Mon, 07 Apr 2014 16:11:14 +0000 Received: by mail-ee0-f50.google.com with SMTP id c13so777469eek.23 for ; Mon, 07 Apr 2014 09:11:12 -0700 (PDT) In-Reply-To: <1396883196.22845.126.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Keir Fraser , tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/07/2014 04:06 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:42 +0100, Julien Grall wrote: >> Now that irq_desc stores the type of the IRQ (e.g level/edge,...), we don't >> need anymore to use specific IRQ function for ARM. > > "need to use specific...for ARM any more" > >> Also replace every call to dt_device_get_irq by platform_get_irq which is >> a wrapper to this function and setup the IRQ type correctly. > > Why platform_*? It's still dt specific isn't it? I didn't want to extend dt_device_get_irq because setting arch.type doesn't belong to the DT code. IHMO, soon this will take another structure in parameter to get the IRQ either from ACPI or DT. -- Julien Grall