From: "Roger Pau Monné" <roger.pau@citrix.com>
To: George Dunlap <dunlapg@umich.edu>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <jbeulich@suse.com>,
Xiantao Zhang <xiantao.zhang@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 2/3] amd-iommu: disable iommu_hap_pt_share with AMD IOMMUs
Date: Tue, 8 Apr 2014 09:29:53 +0200 [thread overview]
Message-ID: <5343A571.6090408@citrix.com> (raw)
In-Reply-To: <CAFLBxZbGgHqEVOj_==0ruf6YZhZZH0NggxW49=U7jeiYHRSRrA@mail.gmail.com>
On 07/04/14 18:54, George Dunlap wrote:
> On Mon, Apr 7, 2014 at 5:51 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
>> On Mon, Apr 07, 2014 at 06:02:03PM +0200, Roger Pau Monne wrote:
>>> According to the comment in p2m.h, AMD IOMMUs don't work correctly
>>> with page types different than p2m_ram_rw when the p2m is shared
>>> between HAP and IOMMU, so disable this sharing when using AMD IOMMUs
>>
>> s/between/amongst/
>
> I would say "between". "Amongst", besides sounding a bit archaic,
> gives me the idea of something being divided up (the bread was shared
> amongst them), as opposed to a single thing used by both (the car was
> shared between them).
Thanks to both (George and Konrad) for spotting those mistakes, will fix
in the next revision.
Roger.
next prev parent reply other threads:[~2014-04-08 7:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 16:02 [PATCH 0/3] Fix grant map/unmap with auto-translated guests Roger Pau Monne
2014-04-07 16:02 ` [PATCH 1/3] iommu: set correct IOMMU entries when iommu_hap_pt_share == 0 Roger Pau Monne
2014-04-07 16:49 ` Konrad Rzeszutek Wilk
2014-04-08 8:30 ` Jan Beulich
2014-04-08 9:19 ` Roger Pau Monné
2014-04-08 9:55 ` Jan Beulich
2014-04-08 14:12 ` Tim Deegan
2014-04-08 15:15 ` Roger Pau Monné
2014-04-08 15:29 ` Jan Beulich
2014-04-13 20:27 ` Tim Deegan
2014-04-16 14:36 ` Roger Pau Monné
2014-04-16 14:41 ` Jan Beulich
2014-04-07 16:02 ` [PATCH 2/3] amd-iommu: disable iommu_hap_pt_share with AMD IOMMUs Roger Pau Monne
2014-04-07 16:51 ` Konrad Rzeszutek Wilk
2014-04-07 16:54 ` George Dunlap
2014-04-08 7:29 ` Roger Pau Monné [this message]
2014-04-08 8:52 ` Jan Beulich
2014-04-08 14:16 ` Tim Deegan
2014-04-08 14:36 ` Jan Beulich
2014-04-08 15:39 ` Roger Pau Monné
2014-04-07 16:02 ` [PATCH 3/3] xen: expose that grant table mappings update the IOMMU Roger Pau Monne
2014-04-08 8:34 ` Ian Campbell
2014-04-08 8:56 ` Jan Beulich
2014-04-08 8:58 ` Ian Campbell
2014-04-08 9:53 ` Jan Beulich
2014-04-08 9:57 ` Ian Campbell
2014-04-08 10:05 ` Jan Beulich
2014-04-08 10:26 ` Ian Campbell
2014-04-08 10:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343A571.6090408@citrix.com \
--to=roger.pau@citrix.com \
--cc=dunlapg@umich.edu \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).