From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 2/3] amd-iommu: disable iommu_hap_pt_share
 with AMD IOMMUs
Date: Tue, 8 Apr 2014 09:29:53 +0200
Message-ID: <5343A571.6090408@citrix.com>
References: <1396886524-16921-1-git-send-email-roger.pau@citrix.com>	<1396886524-16921-3-git-send-email-roger.pau@citrix.com>	<20140407165104.GB3239@phenom.dumpdata.com>
	<CAFLBxZbGgHqEVOj_==0ruf6YZhZZH0NggxW49=U7jeiYHRSRrA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WXQU4-0008JH-RA
	for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 07:30:17 +0000
In-Reply-To: <CAFLBxZbGgHqEVOj_==0ruf6YZhZZH0NggxW49=U7jeiYHRSRrA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <dunlapg@umich.edu>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, Xiantao Zhang <xiantao.zhang@intel.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 07/04/14 18:54, George Dunlap wrote:
> On Mon, Apr 7, 2014 at 5:51 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
>> On Mon, Apr 07, 2014 at 06:02:03PM +0200, Roger Pau Monne wrote:
>>> According to the comment in p2m.h, AMD IOMMUs don't work correctly
>>> with page types different than p2m_ram_rw when the p2m is shared
>>> between HAP and IOMMU, so disable this sharing when using AMD IOMMUs
>>
>> s/between/amongst/
> 
> I would say "between".  "Amongst", besides sounding a bit archaic,
> gives me the idea of something being divided up (the bread was shared
> amongst them), as opposed to a single thing used by both (the car was
> shared between them).

Thanks to both (George and Konrad) for spotting those mistakes, will fix
in the next revision.

Roger.