From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline
Date: Tue, 08 Apr 2014 15:38:16 +0100 [thread overview]
Message-ID: <534409D8.30107@linaro.org> (raw)
In-Reply-To: <1396967787.22845.235.camel@kazak.uk.xensource.com>
On 04/08/2014 03:36 PM, Ian Campbell wrote:
> On Thu, 2014-04-03 at 18:09 +0100, Julien Grall wrote:
>> Currently __cmpxchg_mb is only marked inline. The compiler can decide to not
>> inline this function. In this case, the call to __cmpxchg will be inlined
>> but not optimised. This will result linking failure because of __bad_cmpxchg.
>>
>> Catched by clang 3.5.
>
> "caught".
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> But there is no S-o-b. If you offer one here I'll fix the spelling as I
> commit.
Oops, sorry.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-04-08 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 17:09 [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline Julien Grall
2014-04-08 14:36 ` Ian Campbell
2014-04-08 14:38 ` Julien Grall [this message]
2014-04-08 15:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534409D8.30107@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).