From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline Date: Tue, 08 Apr 2014 15:38:16 +0100 Message-ID: <534409D8.30107@linaro.org> References: <1396544950-21909-1-git-send-email-julien.grall@linaro.org> <1396967787.22845.235.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXXAI-0008Gl-Mm for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 14:38:18 +0000 Received: by mail-ee0-f53.google.com with SMTP id b57so760768eek.40 for ; Tue, 08 Apr 2014 07:38:17 -0700 (PDT) In-Reply-To: <1396967787.22845.235.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/08/2014 03:36 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 18:09 +0100, Julien Grall wrote: >> Currently __cmpxchg_mb is only marked inline. The compiler can decide to not >> inline this function. In this case, the call to __cmpxchg will be inlined >> but not optimised. This will result linking failure because of __bad_cmpxchg. >> >> Catched by clang 3.5. > > "caught". > > Acked-by: Ian Campbell > > But there is no S-o-b. If you offer one here I'll fix the spelling as I > commit. Oops, sorry. Signed-off-by: Julien Grall Regards, -- Julien Grall