From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 2/4] xen: arm: move magic pfns out of guest RAM region Date: Tue, 08 Apr 2014 15:52:35 +0100 Message-ID: <53440D33.1070705@linaro.org> References: <1396966739.22845.233.camel@kazak.uk.xensource.com> <1396966760-7752-2-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396966760-7752-2-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 04/08/2014 03:19 PM, Ian Campbell wrote: > Because toolstacks (at least libxl) only allow RAM to be specified in 1M > increments these two pages were effectively costing 1M of guest RAM space. > > Since these pages don't actually need to live in RAM just move them out. > > With this a guest can now use the full 768M of the address space reserved > for RAM. (ok, not that impressive, but it simplifies things later) > > Signed-off-by: Ian Campbell > --- > tools/libxc/xc_dom_arm.c | 10 +++++----- > xen/include/public/arch-arm.h | 2 ++ > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c > index c085b4a..36b1487 100644 > --- a/tools/libxc/xc_dom_arm.c > +++ b/tools/libxc/xc_dom_arm.c > @@ -58,12 +58,12 @@ static int setup_pgtables_arm(struct xc_dom_image *dom) > static int alloc_magic_pages(struct xc_dom_image *dom) > { > int rc, i; > + const xen_pfn_t base = GUEST_MAGIC_BASE >> PAGE_SHIFT; > xen_pfn_t p2m[NR_MAGIC_PAGES]; > - Spurious change? Apart this minor question: Acked-by: Julien Grall -- Julien Grall