From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/4] tools: arm: report an error if the guest RAM is too large Date: Tue, 08 Apr 2014 16:16:17 +0100 Message-ID: <534412C1.6000303@linaro.org> References: <1396966739.22845.233.camel@kazak.uk.xensource.com> <1396966760-7752-1-git-send-email-ian.campbell@citrix.com> <53440DCC.6010002@linaro.org> <1396969582.22845.245.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396969582.22845.245.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/08/2014 04:06 PM, Ian Campbell wrote: > On Tue, 2014-04-08 at 15:55 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 04/08/2014 03:19 PM, Ian Campbell wrote: >>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h >>> index 7496556..dc11040 100644 >>> --- a/xen/include/public/arch-arm.h >>> +++ b/xen/include/public/arch-arm.h >>> @@ -369,7 +369,8 @@ typedef uint64_t xen_callback_t; >>> #define GUEST_GICC_BASE 0x2c002000ULL >>> #define GUEST_GICC_SIZE 0x100ULL >>> >>> -#define GUEST_RAM_BASE 0x80000000ULL >>> +#define GUEST_RAM_BASE 0x80000000ULL /* 768M at 2GB*/ >>> +#define GUEST_RAM_END 0xafffffffULL >> >> I didn't catch this on the first read, every other pairs of define use >> _BASE AND _SIZE. Can you be consistent here? > > END is what the user of this particular #define needs. You can deal with dom->total_pages. Anyway it was just to stay consistent in the name... > But in any case SIZE gets added later on. Oh right, I didn't see it. -- Julien Grall