From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [V8 PATCH 5/8] pvh dom0: Add and remove foreign
	pages
Date: Tue, 8 Apr 2014 16:40:46 +0100
Message-ID: <5344187E.3010601@eu.citrix.com>
References: <1395452357-1598-1-git-send-email-mukesh.rathor@oracle.com>
	<1395452357-1598-6-git-send-email-mukesh.rathor@oracle.com>
	<5330087202000078000013AA@nat28.tlf.novell.com>
	<20140404181704.0cb0c289@mantra.us.oracle.com>
	<534268940200007800005F7F@nat28.tlf.novell.com>
	<20140407181150.0008e838@mantra.us.oracle.com>
	<5343C33702000078000066B3@nat28.tlf.novell.com>
	<20140408140115.GA27003@deinos.phlegethon.org>
	<53441EB50200007800006AF4@nat28.tlf.novell.com>
	<20140408141840.GD27003@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1WXYBa-00038j-Jk
	for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 15:43:42 +0000
In-Reply-To: <20140408141840.GD27003@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, keir.xen@gmail.com, eddie.dong@intel.com, jun.nakajima@intel.com
List-Id: xen-devel@lists.xenproject.org

On 04/08/2014 03:18 PM, Tim Deegan wrote:
> At 15:07 +0100 on 08 Apr (1396966037), Jan Beulich wrote:
>>>>> On 08.04.14 at 16:01, <tim@xen.org> wrote:
>>> At 08:36 +0100 on 08 Apr (1396942615), Jan Beulich wrote:
>>>>>>> On 08.04.14 at 03:11, <mukesh.rathor@oracle.com> wrote:
>>>>> On Mon, 07 Apr 2014 07:57:56 +0100
>>>>> "Jan Beulich" <JBeulich@suse.com> wrote:
>>>>>> In the end I think we'll want to make them all report proper error
>>>>>> codes...
>>>>>
>>>>> Ok, how about the following patch then? If it's OK, I'd like to submit
>>>>> independently.
>>>>
>>>> Yes, I just now stumbled across this oddity too. Looks generally
>>>> like what we want
>>>
>>> While in general I like this, I'm worried about inverting the sense of
>>> the return code -- that seems like setting a trap for ourselves with
>>> backporting patches past this one.
>>>
>>> I'd be inclined to change the name of the function as a safety catch,
>>> though I can't immediately think of a good new name for set_p2m_entry.
>>> Maybe just truncate it to set_p2m()?
>>
>> That could mean a different thing. How about p2m_set_entry(),
>> at once matching most other P2M functions using p2m_ as their
>> prefix.
>
> Sure.  I think the current implementation in p2m_pt might be using
> that name, but it could be given a more meaningful name at the same
> time.

Ack to the rename.

  -George