From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH 1/3] tools: arm: improve placement of initial modules.
Date: Wed, 09 Apr 2014 13:43:07 +0100 [thread overview]
Message-ID: <5345405B.2070502@linaro.org> (raw)
In-Reply-To: <1397044276-30185-1-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 04/09/2014 12:51 PM, Ian Campbell wrote:
> 314c9815e2f5 "tools: implement initial ramdisk support for ARM." broke starting
> guests with <= 128 MB ram by placing the boot modules (dtb and initrd)
> immediately after the kernel in this case, running the risk of them being
> overwritten. Instead place the modules at the end of RAM, as the hypervisor
> does for dom0.
>
> The hypervisor also falls back to placing things before the kernel as a last
Did you mean "falls backs on placing"?
Other than that the patch looks good to me:
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-04-09 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:50 [PATCH 0/3] xen: arm: fixes for initrd and dtb placement Ian Campbell
2014-04-09 11:51 ` [PATCH 1/3] tools: arm: improve placement of initial modules Ian Campbell
2014-04-09 12:43 ` Julien Grall [this message]
2014-04-09 12:46 ` Ian Campbell
2014-04-10 11:38 ` Ian Campbell
2014-04-10 11:39 ` Ian Jackson
2014-05-22 16:07 ` Ian Jackson
2014-04-09 11:51 ` [PATCH 2/3] xen: arm: use same variables as userspace in dom0 builder place_modules() Ian Campbell
2014-04-09 12:45 ` Julien Grall
2014-04-09 12:52 ` Ian Campbell
2014-04-09 13:37 ` Julien Grall
2014-04-09 11:51 ` [PATCH 3/3] xen: arm: rework dom0 initrd and dtb placement Ian Campbell
2014-04-09 12:54 ` Julien Grall
2014-04-09 12:57 ` Ian Campbell
2014-04-09 13:09 ` Julien Grall
2014-04-09 13:15 ` Ian Campbell
2014-04-09 13:24 ` Julien Grall
2014-04-09 13:28 ` Ian Campbell
2014-04-09 13:35 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345405B.2070502@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).