From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/3] tools: arm: improve placement of initial modules. Date: Wed, 09 Apr 2014 13:43:07 +0100 Message-ID: <5345405B.2070502@linaro.org> References: <1397044259.6275.15.camel@kazak.uk.xensource.com> <1397044276-30185-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397044276-30185-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 04/09/2014 12:51 PM, Ian Campbell wrote: > 314c9815e2f5 "tools: implement initial ramdisk support for ARM." broke starting > guests with <= 128 MB ram by placing the boot modules (dtb and initrd) > immediately after the kernel in this case, running the risk of them being > overwritten. Instead place the modules at the end of RAM, as the hypervisor > does for dom0. > > The hypervisor also falls back to placing things before the kernel as a last Did you mean "falls backs on placing"? Other than that the patch looks good to me: Acked-by: Julien Grall Regards, -- Julien Grall