Re: [PATCH 2/3] xen: arm: use same variables as userspace in dom0 builder place_modules()

[Julien Grall <julien.grall@linaro.org>]

On 04/09/2014 12:51 PM, Ian Campbell wrote:
>  static void place_modules(struct kernel_info *info,
> -                         paddr_t kernel_start,
> -                         paddr_t kernel_end)
> +                          paddr_t kernbase, paddr_t kernend)
>  {
>      /* Align DTB and initrd size to 2Mb. Linux only requires 4 byte alignment */
>      const paddr_t initrd_len =
>          ROUNDUP(early_info.modules.module[MOD_INITRD].size, MB(2));
>      const paddr_t dtb_len = ROUNDUP(fdt_totalsize(info->fdt), MB(2));
> -    const paddr_t total = initrd_len + dtb_len;
> +    const paddr_t modsize = initrd_len + dtb_len;
>  
>      /* Convenient */
> -    const paddr_t mem_start = info->mem.bank[0].start;
> -    const paddr_t mem_size = info->mem.bank[0].size;
> -    const paddr_t mem_end = mem_start + mem_size;
> -    const paddr_t kernel_size = kernel_end - kernel_start;
> +    const paddr_t rambase = info->mem.bank[0].start;
> +    const paddr_t ramsize = info->mem.bank[0].size;
> +    const paddr_t ramend = rambase + ramsize;
> +    const paddr_t kernsize = kernend - kernbase;
> +    const paddr_t ram128mb = rambase + MB(128);

Shall we use ram0base, ram0size, ram0end to show that we are using that
the first bank?

Regards,

-- 
Julien Grall