From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 3/3] xen: arm: rework dom0 initrd and dtb placement Date: Wed, 09 Apr 2014 14:35:13 +0100 Message-ID: <53454C91.2070600@linaro.org> References: <1397044259.6275.15.camel@kazak.uk.xensource.com> <1397044276-30185-3-git-send-email-ian.campbell@citrix.com> <53454319.9060204@linaro.org> <1397048252.6275.37.camel@kazak.uk.xensource.com> <53454689.7040705@linaro.org> <1397049325.6275.40.camel@kazak.uk.xensource.com> <53454A10.4040605@linaro.org> <1397050094.6275.50.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397050094.6275.50.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/09/2014 02:28 PM, Ian Campbell wrote: > > Ah, you mean the lack of rounding in the first if: > if ( ramend >= ram128mb + modsize && kernend < ram128mb ) > ? > > Since ram128mb is 2MB aligned it doesn't really matter that kernend > isn't. Oh right, I was lost with all the arithmetic. >> In another point, I don't think 2MB-aligned is enough to ensure the >> kernel won't decompress on the device tree. > > Yes, like I say I don't know if it actually worthwhile. Ok. Let's stick with this solution and see if someone platform will complain: Acked-by: Julien Grall -- Julien Grall