From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 2/3] xen: arm: use same variables as userspace in dom0 builder place_modules() Date: Wed, 09 Apr 2014 14:37:03 +0100 Message-ID: <53454CFF.8030906@linaro.org> References: <1397044259.6275.15.camel@kazak.uk.xensource.com> <1397044276-30185-2-git-send-email-ian.campbell@citrix.com> <53454105.2000008@linaro.org> <1397047972.6275.30.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397047972.6275.30.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/09/2014 01:52 PM, Ian Campbell wrote: > On Wed, 2014-04-09 at 13:45 +0100, Julien Grall wrote: >> On 04/09/2014 12:51 PM, Ian Campbell wrote: >>> static void place_modules(struct kernel_info *info, >>> - paddr_t kernel_start, >>> - paddr_t kernel_end) >>> + paddr_t kernbase, paddr_t kernend) >>> { >>> /* Align DTB and initrd size to 2Mb. Linux only requires 4 byte alignment */ >>> const paddr_t initrd_len = >>> ROUNDUP(early_info.modules.module[MOD_INITRD].size, MB(2)); >>> const paddr_t dtb_len = ROUNDUP(fdt_totalsize(info->fdt), MB(2)); >>> - const paddr_t total = initrd_len + dtb_len; >>> + const paddr_t modsize = initrd_len + dtb_len; >>> >>> /* Convenient */ >>> - const paddr_t mem_start = info->mem.bank[0].start; >>> - const paddr_t mem_size = info->mem.bank[0].size; >>> - const paddr_t mem_end = mem_start + mem_size; >>> - const paddr_t kernel_size = kernel_end - kernel_start; >>> + const paddr_t rambase = info->mem.bank[0].start; >>> + const paddr_t ramsize = info->mem.bank[0].size; >>> + const paddr_t ramend = rambase + ramsize; >>> + const paddr_t kernsize = kernend - kernbase; >>> + const paddr_t ram128mb = rambase + MB(128); >> >> Shall we use ram0base, ram0size, ram0end to show that we are using that >> the first bank? > > I was planning to do that in my 1TB RAM series, but this is different > code isn't it. Oops. > > I'll change if there is some other reason to repost, but I don't think > it is worth reposting just for that. Ok. With or without this change: Acked-by: Julien Grall -- Julien Grall