From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v2 07/10] hvm/hpet: Call hpet_get_comparator during hpet_save. Date: Mon, 14 Apr 2014 20:21:17 -0400 Message-ID: <534C7B7D.7070609@terremark.com> References: <1396967094-29484-1-git-send-email-dslutz@verizon.com> <1396967094-29484-8-git-send-email-dslutz@verizon.com> <534C175202000078000088CE@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534C175202000078000088CE@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Don Slutz Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/14/14 11:13, Jan Beulich wrote: >>>> On 08.04.14 at 16:24, wrote: >> This changes save data to consistent/expected values. It is not >> technically required because hpet_get_comparator() will adjust from >> any value to the correct value. > So am I getting it right that this is just to alter what's in the save image > then? Yes. > I'm somewhat confused by the wording above, which I first read > mostly like "here is a change that we don't need". This is a change that is only "needed" with patch #10 "handle 1st period special". However it does look strange to people that the output from xen-hvmctx for the comparator values do not change when the master clock does. Since hpet_get_comparator() will always adjust the current value of comparator to the current value of the master clock, migration just "works". -Don Slutz > Jan >