From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 01/16] xen/arm: move io.h as mmio.h to
	include folder
Date: Tue, 15 Apr 2014 17:36:11 +0100
Message-ID: <534D5FFB.8050001@linaro.org>
References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com>
	<1397560675-29861-2-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1397560675-29861-2-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

Thank you for the patch.

On 04/15/2014 12:17 PM, vijay.kilari@gmail.com wrote:
> diff --git a/xen/include/asm-arm/mmio.h b/xen/include/asm-arm/mmio.h
> new file mode 100644
> index 0000000..44b28a6
> --- /dev/null
> +++ b/xen/include/asm-arm/mmio.h
> @@ -0,0 +1,57 @@
> +/*
> + * xen/arch/arm/mmio.h

include/asm-arm/mmio.h

> + *
> + * ARM I/O handlers
> + *
> + * Copyright (c) 2011 Citrix Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ARCH_ARM_MMIO_H__
> +#define __ARCH_ARM_MMIO_H__

The line should be

#ifndef __ASM_ARM_MMIO_H__
#define __ASM_ARM_MMIO_H__

> +
> +#include <xen/lib.h>
> +#include <asm/processor.h>
> +#include <asm/regs.h>
> +
> +typedef struct
> +{
> +    struct hsr_dabt dabt;
> +    vaddr_t gva;
> +    paddr_t gpa;
> +} mmio_info_t;
> +
> +typedef int (*mmio_read_t)(struct vcpu *v, mmio_info_t *info);
> +typedef int (*mmio_write_t)(struct vcpu *v, mmio_info_t *info);
> +typedef int (*mmio_check_t)(struct vcpu *v, paddr_t addr);
> +
> +struct mmio_handler {
> +    mmio_check_t check_handler;
> +    mmio_read_t read_handler;
> +    mmio_write_t write_handler;
> +};
> +
> +extern const struct mmio_handler vgic_distr_mmio_handler;
> +extern const struct mmio_handler vuart_mmio_handler;
> +
> +extern int handle_mmio(mmio_info_t *info);
> +
> +#endif

#endif /* __ASM_ARM_MMIO_H__ */

Regards,

-- 
Julien Grall