From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 03/16] xen/arm: make sgi handling generic Date: Tue, 15 Apr 2014 18:57:40 +0100 Message-ID: <534D7314.2090504@linaro.org> References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com> <1397560675-29861-4-git-send-email-vijay.kilari@gmail.com> <534D71A1.4050702@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534D71A1.4050702@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/15/2014 06:51 PM, Julien Grall wrote: >> void smp_send_state_dump(unsigned int cpu) >> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h >> index 5d8f7f1..d03b490 100644 >> --- a/xen/include/asm-arm/gic.h >> +++ b/xen/include/asm-arm/gic.h >> @@ -50,6 +50,10 @@ >> #define GICD_SPENDSGIRN (0xF2C/4) >> #define GICD_ICPIDR2 (0xFE8/4) >> >> +#define SGI_TARGET_LIST 0 >> +#define SGI_TARGET_OTHERS 1 >> +#define SGI_TARGET_SELF 2 >> + > > You don't need to export it. It's used internally... I forgot that it means to be used with both V2 and V3... My remarks stay unchanged for the enum things. -- Julien Grall