From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC v2 4/6] xen/arm: Implement VLPT for guest p2m mapping in live migration Date: Tue, 15 Apr 2014 23:29:48 +0100 Message-ID: <534DB2DC.7070205@linaro.org> References: <1397595918-30419-1-git-send-email-w1.huang@samsung.com> <1397595918-30419-5-git-send-email-w1.huang@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397595918-30419-5-git-send-email-w1.huang@samsung.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Huang , xen-devel@lists.xen.org Cc: andrew.cooper3@citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, jaeyong.yoo@samsung.com, yjhyun.yoo@samsung.com List-Id: xen-devel@lists.xenproject.org Hello Wei, Thank you for the patch. On 15/04/14 22:05, Wei Huang wrote: > diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h > index ef291ff..47d1bce 100644 > --- a/xen/include/asm-arm/config.h > +++ b/xen/include/asm-arm/config.h > @@ -87,6 +87,7 @@ > * 0 - 8M > * > * 32M - 128M Frametable: 24 bytes per page for 16GB of RAM > + * 128M - 256M Virtual-linear mapping to P2M table > * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address > * space > * > @@ -124,7 +125,9 @@ > #define CONFIG_SEPARATE_XENHEAP 1 > > #define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) > +#define VIRT_LIN_P2M_START _AT(vaddr_t,0x08000000) > #define VMAP_VIRT_START _AT(vaddr_t,0x10000000) > +#define VIRT_LIN_P2M_END VMAP_VIRT_START Should not it be VMAP_VIRT_START - 1? I would also directly use _AT(vaddr_t, 0x0fffffff) to stay consistent with the other *_END define. I will review the rest of this patch soon. Regards, -- Julien Grall