From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2 03/10] hvm/hpet: Only set comparator or
 period not both.
Date: Wed, 16 Apr 2014 00:06:24 -0400
Message-ID: <534E01C0.3010907@terremark.com>
References: <1396967094-29484-1-git-send-email-dslutz@verizon.com>
	<1396967094-29484-4-git-send-email-dslutz@verizon.com>
	<534C13B6020000780000889D@nat28.tlf.novell.com>
	<534C66EE.2050303@terremark.com>
	<534CF50E0200007800008CAE@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <534CF50E0200007800008CAE@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


On 04/15/14 02:59, Jan Beulich wrote:
>>>> On 15.04.14 at 00:53, <dslutz@verizon.com> wrote:
> Yes, with a minor comment.

...

>> +            if ( timer_is_32bit(h, tn) )
>> +                h->hpet.timers[tn].cmp = (uint32_t)new_val;
>> +            else
>> +                h->hpet.timers[tn].cmp = new_val;
> I'd continue to do the truncation on new_val, and write just once
> (as the old code did).

Will do in v3.
     -Don Slutz

> Jan
>