From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC v2 3/6] xen/arm: support guest do_suspend
	function
Date: Wed, 16 Apr 2014 10:10:49 +0100
Message-ID: <534E4919.9050709@linaro.org>
References: <w1.huang@samsung.com>
	<1397595918-30419-1-git-send-email-w1.huang@samsung.com>
	<1397595918-30419-4-git-send-email-w1.huang@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1397595918-30419-4-git-send-email-w1.huang@samsung.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Huang <w1.huang@samsung.com>, xen-devel@lists.xen.org
Cc: andrew.cooper3@citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, jaeyong.yoo@samsung.com, yjhyun.yoo@samsung.com
List-Id: xen-devel@lists.xenproject.org

Hello Wei,

Thank you for the patch.

On 15/04/14 22:05, Wei Huang wrote:
> +#elif defined(__arm__) || defined(__aarch64__)
> +
> +static int modify_returncode(xc_interface *xch, uint32_t domid)
> +{
> +    vcpu_guest_context_any_t ctxt;
> +    xc_dominfo_t info;
> +    int rc;
> +
> +    if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 )
> +    {
> +        PERROR("Could not get domain info");
> +        return -EINVAL;
> +    }
> +
> +    if ( (rc = xc_vcpu_getcontext(xch, domid, 0, &ctxt)) != 0 )
> +        return rc;
> +
> +    ctxt.c.user_regs.r0_usr = 1;

r0_usr is only for 32-bit. I think you need to use x0 is you are 
restoring a 64-bits guest.

Regards,

-- 
Julien Grall