From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 10/18] xen/arm: IRQ: Require desc.lock
 held by callers of hw_irq_controller callbacks
Date: Wed, 16 Apr 2014 16:39:11 +0100
Message-ID: <534EA41F.50005@linaro.org>
References: <1396968247-8768-1-git-send-email-julien.grall@linaro.org>
	<1396968247-8768-11-git-send-email-julien.grall@linaro.org>
	<1397662576.24638.214.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WaRve-0001zz-Ip
	for xen-devel@lists.xenproject.org; Wed, 16 Apr 2014 15:39:14 +0000
Received: by mail-ee0-f46.google.com with SMTP id t10so8963579eei.19
	for <xen-devel@lists.xenproject.org>;
	Wed, 16 Apr 2014 08:39:12 -0700 (PDT)
In-Reply-To: <1397662576.24638.214.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 04/16/2014 04:36 PM, Ian Campbell wrote:
> On Tue, 2014-04-08 at 15:43 +0100, Julien Grall wrote:
>> When multiple action are supported, gic_irq_{startup,shutdown} will have
>> to be called in the same critical section as setup/release.
>> Otherwise there is a race condition if at the same time CPU A is calling
>> release_dt_irq and CPU B is calling setup_dt_irq.
>>
>> This could end up with the IRQ not being enabled.
>>
>> At the same time, modify gic_irq_{enable,disable} to require desc.lock held.
> 
> "require that ... is held" or "require ... be held".

I guess, I also have to update the commit title, rigth?

I plan to change into:

"Require desc.lock be held by callers of hw_irq_controller callbacks"

>>
>> With this both changes, ARM's locking requirements is the same as x86's.
> 
> "With both of these changes..."
> 
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks,

-- 
Julien Grall