From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
ian.campbell@citrix.com, tim@xen.org,
stefano.stabellini@citrix.com,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xenproject.org,
Xiantao Zhang <xiantao.zhang@intel.com>
Subject: Re: [PATCH v3 17/18] xen/arm: IRQ: extend {request, setup}_irq to take an irqflags in parameter
Date: Wed, 16 Apr 2014 16:46:24 +0100 [thread overview]
Message-ID: <534EA5D0.2090800@linaro.org> (raw)
In-Reply-To: <53442A9C0200007800006C5B@nat28.tlf.novell.com>
Hi Jan,
On 04/08/2014 03:58 PM, Jan Beulich wrote:
>>>> On 08.04.14 at 16:44, <julien.grall@linaro.org> wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -949,7 +949,7 @@ static int __init irq_ratelimit_init(void)
>> }
>> __initcall(irq_ratelimit_init);
>>
>> -int __init request_irq(unsigned int irq,
>> +int __init request_irq(unsigned int irq, unsigned int irqflags,
>> void (*handler)(int, void *, struct cpu_user_regs *),
>> const char * devname, void *dev_id)
>> {
>> @@ -976,7 +976,7 @@ int __init request_irq(unsigned int irq,
>> action->dev_id = dev_id;
>> action->free_on_release = 1;
>>
>> - retval = setup_irq(irq, action);
>> + retval = setup_irq(irq, 0, action);
>
> You should be passing irqflags here.
Oops right. I will fix it in the next version of this series.
> With that, for x86 and IOMMU:
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks,
--
Julien Grall
next prev parent reply other threads:[~2014-04-16 15:46 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 14:43 [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-08 14:43 ` [PATCH v3 01/18] xen/arm: timer: replace timer_dt_irq by timer_get_irq Julien Grall
2014-04-16 15:27 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type Julien Grall
2014-04-08 14:43 ` [PATCH v3 03/18] xen/arm: IRQ: Rename irq_cfg into arch_irq_desc Julien Grall
2014-04-08 14:43 ` [PATCH v3 04/18] xen/arm: IRQ: move gic {, un}lock in gic_set_irq_properties Julien Grall
2014-04-08 14:43 ` [PATCH v3 05/18] xen/arm: IRQ: drop irq parameter in __setup_irq Julien Grall
2014-04-08 14:43 ` [PATCH v3 06/18] xen/arm: IRQ: remove __init from setup_dt_irq, request_dt_irq and release_irq Julien Grall
2014-04-08 14:43 ` [PATCH v3 07/18] xen/arm: IRQ: Rework gic_route_irq_to_guest function Julien Grall
2014-04-16 15:31 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 08/18] xen/arm: IRQ: Move IRQ management from gic.c to irq.c Julien Grall
2014-04-17 10:38 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 09/18] xen/arm: IRQ Introduce irq_get_domain Julien Grall
2014-04-08 14:43 ` [PATCH v3 10/18] xen/arm: IRQ: Require desc.lock held by callers of hw_irq_controller callbacks Julien Grall
2014-04-16 15:36 ` Ian Campbell
2014-04-16 15:39 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 11/18] xen/arm: IRQ: Defer routing IRQ to Xen until setup_irq() call Julien Grall
2014-04-16 15:39 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 12/18] xen/arm: IRQ: Do not allow IRQ to be shared between domains and XEN Julien Grall
2014-04-16 15:40 ` Ian Campbell
2014-04-21 19:16 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 13/18] xen/serial: remove serial_dt_irq Julien Grall
2014-04-17 10:22 ` Julien Grall
2014-04-17 10:35 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Julien Grall
2014-04-16 15:45 ` Ian Campbell
2014-04-16 15:52 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 15/18] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq Julien Grall
2014-04-16 15:46 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 16/18] xen: IRQ: Add dev_id parameter to release_irq Julien Grall
2014-04-08 14:55 ` Jan Beulich
2014-04-16 15:47 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 17/18] xen/arm: IRQ: extend {request, setup}_irq to take an irqflags in parameter Julien Grall
2014-04-08 14:58 ` Jan Beulich
2014-04-16 15:46 ` Julien Grall [this message]
2014-04-16 15:48 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 18/18] xen/arm: IRQ: Handle multiple action per IRQ Julien Grall
2014-04-08 14:59 ` Jan Beulich
2014-04-16 16:01 ` Julien Grall
2014-04-16 15:54 ` Ian Campbell
2014-04-16 16:06 ` Julien Grall
2014-04-16 16:17 ` Ian Campbell
2014-04-16 16:21 ` Jan Beulich
2014-04-16 16:23 ` Julien Grall
2014-04-17 7:07 ` Jan Beulich
2014-04-17 10:36 ` Julien Grall
2014-04-17 11:15 ` Jan Beulich
2014-04-17 11:22 ` Julien Grall
2014-04-17 11:36 ` Ian Campbell
2014-04-17 12:18 ` Julien Grall
2014-04-17 12:27 ` Ian Campbell
2014-04-17 12:35 ` Julien Grall
2014-04-17 10:26 ` [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-17 10:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EA5D0.2090800@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).