From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 17/18] xen/arm: IRQ: extend {request,
 setup}_irq to take an irqflags in parameter
Date: Wed, 16 Apr 2014 16:46:24 +0100
Message-ID: <534EA5D0.2090800@linaro.org>
References: <1396968247-8768-1-git-send-email-julien.grall@linaro.org>
	<1396968247-8768-18-git-send-email-julien.grall@linaro.org>
	<53442A9C0200007800006C5B@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WaS2h-0002tx-Hc
	for xen-devel@lists.xenproject.org; Wed, 16 Apr 2014 15:46:31 +0000
Received: by mail-ee0-f42.google.com with SMTP id d17so9055167eek.1
	for <xen-devel@lists.xenproject.org>;
	Wed, 16 Apr 2014 08:46:25 -0700 (PDT)
In-Reply-To: <53442A9C0200007800006C5B@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, ian.campbell@citrix.com, tim@xen.org, stefano.stabellini@citrix.com, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, xen-devel@lists.xenproject.org, Xiantao Zhang <xiantao.zhang@intel.com>
List-Id: xen-devel@lists.xenproject.org

Hi Jan,

On 04/08/2014 03:58 PM, Jan Beulich wrote:
>>>> On 08.04.14 at 16:44, <julien.grall@linaro.org> wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -949,7 +949,7 @@ static int __init irq_ratelimit_init(void)
>>  }
>>  __initcall(irq_ratelimit_init);
>>  
>> -int __init request_irq(unsigned int irq,
>> +int __init request_irq(unsigned int irq, unsigned int irqflags,
>>          void (*handler)(int, void *, struct cpu_user_regs *),
>>          const char * devname, void *dev_id)
>>  {
>> @@ -976,7 +976,7 @@ int __init request_irq(unsigned int irq,
>>      action->dev_id = dev_id;
>>      action->free_on_release = 1;
>>  
>> -    retval = setup_irq(irq, action);
>> +    retval = setup_irq(irq, 0, action);
> 
> You should be passing irqflags here.

Oops right. I will fix it in the next version of this series.

> With that, for x86 and IOMMU:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks,

-- 
Julien Grall