From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v4 1/3] x86: Use native RDTSC(P) execution when guest and host frequencies are the same Date: Wed, 16 Apr 2014 12:44:02 -0400 Message-ID: <534EB352.2000207@oracle.com> References: <1397611668-15338-1-git-send-email-boris.ostrovsky@oracle.com> <1397611668-15338-2-git-send-email-boris.ostrovsky@oracle.com> <534E87DE0200007800009787@nat28.tlf.novell.com> <534E9393.6080402@oracle.com> <534EB1D502000078000099A9@nat28.tlf.novell.com> <534EA2BC.4050000@oracle.com> <534EC8C50200007800009B44@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534EC8C50200007800009B44@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com List-Id: xen-devel@lists.xenproject.org On 04/16/2014 12:15 PM, Jan Beulich wrote: > Please sort this out with Mukesh - I would generally have thought that > time handling should be HVM-like for PVH, and was surprised (in the > sense that I didn't recall) to find that fixme comment there when > reviewing your patch. Do you want PVH issues be resolved in this series or separately? -boris > >> PVH need to be looked at anyway. For example, there is a is_hvm_domain() >> check at the bottom which I suspect needs to be PVH-safe. > Indeed this all looks rather suspicious... > > Jan >