From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 13/16] xen/arm: Add support for GIC v3
Date: Thu, 17 Apr 2014 10:02:22 +0100
Message-ID: <534F989E.8040502@linaro.org>
References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com>
	<1397560675-29861-14-git-send-email-vijay.kilari@gmail.com>
	<534D9A0D.3050606@linaro.org>
	<CALicx6vr+FAgQD8zW=Bsd8eEUx3DA4-SbCSCkgUB9g-dn+GXVQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6vr+FAgQD8zW=Bsd8eEUx3DA4-SbCSCkgUB9g-dn+GXVQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/17/2014 08:09 AM, Vijay Kilari wrote:
>>> +                if ( typer & GICR_TYPER_VLPIS )
>>> +                    ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
>>> +            }
>>> +        } while ( !(typer & GICR_TYPER_LAST) );
>>> +    }
>>> +
>>> +    dprintk(XENLOG_WARNING, "CPU%d: mpidr %"PRIpaddr" has no re-distributor!\n",
>>> +                  smp_processor_id(), mpidr);
>>
>> What happen if you don't have re-distributor?
>>
>   I think, we can't handle SGI & PPI's. As configuration and handling of these
> is done in GICR region. May be I can change it to BUG_ON

Please, no BUG_ON. As I said previously, you have to propagate the error
code. It will be useful for CPU hotplug later.

-- 
Julien Grall