From: David Vrabel <dvrabel@cantab.net>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>,
Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/pygrub: store kernels in /var/run/pygrub
Date: Thu, 17 Apr 2014 12:33:29 +0100 [thread overview]
Message-ID: <534FBC09.40507@cantab.net> (raw)
In-Reply-To: <534FB383.5060806@citrix.com>
On 17/04/14 11:57, Andrew Cooper wrote:
> On 17/04/14 11:52, Olaf Hering wrote:
>> Move location of temporary bootfiles from /var/run/xend/boot to
>> /var/run/pygrub. If the directory does not exist create it, unless
>> --output-directory=<dir> was specified.
>>
>> The reason for this change is that all entrys below /var/run have to be
>> created at runtime in case /var/run is cleared on every boot.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> ---
>>
>> New code not runtime tested as pygrub, just as hello_world.py...
>
> I don't think it is valid in the slightest for programs like this to be
> mkdir()ing their environment. It is very much a packaging responsibility.
/var/run may not be persistent so this can't be done by the packaging.
David
next prev parent reply other threads:[~2014-04-17 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 10:52 [PATCH] tools/pygrub: store kernels in /var/run/pygrub Olaf Hering
2014-04-17 10:57 ` Andrew Cooper
2014-04-17 11:07 ` Olaf Hering
2014-04-17 11:33 ` David Vrabel [this message]
2014-04-17 18:18 ` Ian Jackson
2014-04-22 8:45 ` Ian Campbell
2014-04-22 12:55 ` Olaf Hering
2014-04-22 13:55 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FBC09.40507@cantab.net \
--to=dvrabel@cantab.net \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).