From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
stefano.stabellini@citrix.com, Jan Beulich <JBeulich@suse.com>,
tim@xen.org
Subject: Re: [PATCH v3 18/18] xen/arm: IRQ: Handle multiple action per IRQ
Date: Thu, 17 Apr 2014 13:18:06 +0100 [thread overview]
Message-ID: <534FC67E.3010602@linaro.org> (raw)
In-Reply-To: <1397734580.24638.297.camel@kazak.uk.xensource.com>
On 04/17/2014 12:36 PM, Ian Campbell wrote:
> On Thu, 2014-04-17 at 12:22 +0100, Julien Grall wrote:
>> On 04/17/2014 12:15 PM, Jan Beulich wrote:
>>>>>> On 17.04.14 at 12:36, <julien.grall@linaro.org> wrote:
>>>> In Linux case, they are safe because they are using a single linked list.
>>>
>>> And is there a strong reason for us to use a doubly linked one?
>>
>> My first version was single-linked list... Ian asked me to use generic
>> list on V1 to avoid open code.
>
> I also suggested that you could import a single linked list
> implementation if you thought it would be better.
>
>> I was looking to port llist.h from Linux but it seems a bit overkill for
>> action list.
>
> I don't see why. I'm sure there are other potential uses of singly
> linked lists which people just used a double list because it was simpler
> at the time.
They are using xchg and AFAIU it's not possible to delete an element
anywhere in the list. See:
http://lxr.free-electrons.com/source/include/linux/llist.h
--
Julien Grall
next prev parent reply other threads:[~2014-04-17 12:18 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 14:43 [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-08 14:43 ` [PATCH v3 01/18] xen/arm: timer: replace timer_dt_irq by timer_get_irq Julien Grall
2014-04-16 15:27 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type Julien Grall
2014-04-08 14:43 ` [PATCH v3 03/18] xen/arm: IRQ: Rename irq_cfg into arch_irq_desc Julien Grall
2014-04-08 14:43 ` [PATCH v3 04/18] xen/arm: IRQ: move gic {, un}lock in gic_set_irq_properties Julien Grall
2014-04-08 14:43 ` [PATCH v3 05/18] xen/arm: IRQ: drop irq parameter in __setup_irq Julien Grall
2014-04-08 14:43 ` [PATCH v3 06/18] xen/arm: IRQ: remove __init from setup_dt_irq, request_dt_irq and release_irq Julien Grall
2014-04-08 14:43 ` [PATCH v3 07/18] xen/arm: IRQ: Rework gic_route_irq_to_guest function Julien Grall
2014-04-16 15:31 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 08/18] xen/arm: IRQ: Move IRQ management from gic.c to irq.c Julien Grall
2014-04-17 10:38 ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 09/18] xen/arm: IRQ Introduce irq_get_domain Julien Grall
2014-04-08 14:43 ` [PATCH v3 10/18] xen/arm: IRQ: Require desc.lock held by callers of hw_irq_controller callbacks Julien Grall
2014-04-16 15:36 ` Ian Campbell
2014-04-16 15:39 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 11/18] xen/arm: IRQ: Defer routing IRQ to Xen until setup_irq() call Julien Grall
2014-04-16 15:39 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 12/18] xen/arm: IRQ: Do not allow IRQ to be shared between domains and XEN Julien Grall
2014-04-16 15:40 ` Ian Campbell
2014-04-21 19:16 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 13/18] xen/serial: remove serial_dt_irq Julien Grall
2014-04-17 10:22 ` Julien Grall
2014-04-17 10:35 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Julien Grall
2014-04-16 15:45 ` Ian Campbell
2014-04-16 15:52 ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 15/18] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq Julien Grall
2014-04-16 15:46 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 16/18] xen: IRQ: Add dev_id parameter to release_irq Julien Grall
2014-04-08 14:55 ` Jan Beulich
2014-04-16 15:47 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 17/18] xen/arm: IRQ: extend {request, setup}_irq to take an irqflags in parameter Julien Grall
2014-04-08 14:58 ` Jan Beulich
2014-04-16 15:46 ` Julien Grall
2014-04-16 15:48 ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 18/18] xen/arm: IRQ: Handle multiple action per IRQ Julien Grall
2014-04-08 14:59 ` Jan Beulich
2014-04-16 16:01 ` Julien Grall
2014-04-16 15:54 ` Ian Campbell
2014-04-16 16:06 ` Julien Grall
2014-04-16 16:17 ` Ian Campbell
2014-04-16 16:21 ` Jan Beulich
2014-04-16 16:23 ` Julien Grall
2014-04-17 7:07 ` Jan Beulich
2014-04-17 10:36 ` Julien Grall
2014-04-17 11:15 ` Jan Beulich
2014-04-17 11:22 ` Julien Grall
2014-04-17 11:36 ` Ian Campbell
2014-04-17 12:18 ` Julien Grall [this message]
2014-04-17 12:27 ` Ian Campbell
2014-04-17 12:35 ` Julien Grall
2014-04-17 10:26 ` [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-17 10:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FC67E.3010602@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).