From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] hypercall/mem: Introduce
	XENMEM_machphys_compat_mfn_list
Date: Thu, 17 Apr 2014 13:25:18 +0100
Message-ID: <534FC82E.9030208@citrix.com>
References: <1397733014-26715-1-git-send-email-andrew.cooper3@citrix.com>
	<534FDA3C0200007800009FA4@nat28.tlf.novell.com>
	<534FC1CB.5060006@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <534FC1CB.5060006@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/04/14 12:58, Andrew Cooper wrote:
> On 17/04/14 12:42, Jan Beulich wrote:
>
>> Knowing where that is would help judging on the need for this
>> patch (and I don't want to waste time hunting for it knowing that you
>> already spotted it)...
> The bug is in canonicalize_pagetable() in xc_domain_save.c
>
> The search for affected L2 tables at line 445 will never succeed for a
> 64 bit guest, and the decision at line 500 will fail to identify any
> errors which should be fatal.

I do in fact mean 32 bit guest and 64 bit toolstack.

~Andrew